fix: return image pull stream errors#288
Open
mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
Open
fix: return image pull stream errors#288mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
Conversation
Signed-off-by: puneeth_aditya_5656 <myakampuneeth@gmail.com>
mugiwaraluffy56
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks the error returned while copying Docker image pull output during container creation. Before this, a read error from the pull stream was ignored and the command continued toward container creation, which could hide the real failure.
The copy logic is kept small and covered with connector tests for both success and read failure paths.
Tested with go test ./... and make build-binaries.