fix: honor saved insecure TLS setting#287
Open
mynk8 wants to merge 1 commit intomicrocks:masterfrom
Open
Conversation
Signed-off-by: mynk8 <mr.mayankgame@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes saved context TLS semantics. After login, later commands should use the same TLS policy that was persisted for that Microcks server.
loginwas always storinginsecureTLS: true, even when--insecure-tlswas not passed. At the same time, later commands were not honoring the saved context value when creating the HTTP client.This PR makes the behavior consistent:
insecureTLSfrom the actual login flag valueNewClient()Testing
go test ./pkg/connectorsAlso verified manually with a real Microcks uber container behind a self-signed HTTPS proxy.
Also follows up the changes from #180 . That fix made the current
--insecure-tlsflag apply to client construction. This PR covers the saved-context side:loginnow persists the flag value, and later context-based commands honor that persisted setting.Fixes #286