fix: code quality improvements vet target, bug fixes, and typo corrections#284
Open
patilpratik1905 wants to merge 1 commit intomicrocks:masterfrom
Open
fix: code quality improvements vet target, bug fixes, and typo corrections#284patilpratik1905 wants to merge 1 commit intomicrocks:masterfrom
patilpratik1905 wants to merge 1 commit intomicrocks:masterfrom
Conversation
patilpratik1905
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
…; add vet target to Makefile Signed-off-by: Pratik Patil <pratikgpatil1905@gmail.com>
patilpratik1905
force-pushed
the
small_fix/typos_bug_addVet
branch
from
ab6f5a1 to
398bcce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
1. Add
vettarget to MakefileAdded
make vettarget that runsgo vet ./...across all packages.Enables standardized static analysis locally and in CI pipelines.
2. Fix
fmt.Errorfresult not used (pkg/watcher/executor.go)fmt.Errorf(...)was called but its return value was discarded, silentlyswallowing the error. Replaced with
fmt.Printf(...)so the error isactually printed to output.
3. Fix
DownloadArtifactreading wrong body (pkg/connectors/microcks_client.go)io.ReadAll(req.Body)was reading the request body instead of the responsebody after the HTTP call completed. This caused the function to always return
empty data. Fixed to
io.ReadAll(resp.Body).4. Fix function name typo (
pkg/connectors/microcks_client.go)Renamed
ensureValieOAuth2Context→ensureValidOAuth2Context.Updated both the function definition and its call site.
Testing
make vetnow passes with no errorsRelated issue(s)
NA