Inject version commit and build tag metadata with Makefile.#276
Open
mynk8 wants to merge 3 commits intomicrocks:masterfrom
Open
Inject version commit and build tag metadata with Makefile.#276mynk8 wants to merge 3 commits intomicrocks:masterfrom
mynk8 wants to merge 3 commits intomicrocks:masterfrom
Conversation
mynk8
force-pushed
the
fix-version-commit-metadata
branch
from
1dad150 to
b19d0be
Compare
Signed-off-by: mynk8 <mr.mayankgame@gmail.com>
mynk8
force-pushed
the
fix-version-commit-metadata
branch
from
b19d0be to
404860f
Compare
Signed-off-by: mynk8 <mr.mayankgame@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the existing Makefile build flow to inject version and commit metadata at build time.
For local/source builds, the version is derived from
git describe --tags --dirty --always, so unreleased binaries include the nearest tag, commit distance, commit hash, and dirty state when applicable:In a tagged release,
make build-releaseuses the exact git tag as the version.This also wires Cobra's standard
--versionflag to the same output asmicrocks version.The Makefile now keeps
VERSIONandCOMMIToverridable and also allows customGO/BUILD_FLAGSparameters, which makes source packaging and downstream build wrappers easier without changing the target logic.Related issue(s)
Fixes #275