Define own NetworkPolicyPort field.#219
Merged
Merged
Conversation
Gerrit91
commented
May 11, 2026
| func calculatePorts(ports []firewallv1.NetworkPolicyPort) (tcpPorts, udpPorts []string) { | ||
| for _, p := range ports { | ||
| proto := proto(p.Protocol) | ||
| portStr := fmt.Sprint(p.Port) |
Contributor
Author
There was a problem hiding this comment.
I am not sure if this really worked before in case nil was provided? 🙈
Contributor
Author
There was a problem hiding this comment.
Took out the pointer possibility as to me it looked like this was not working.
majst01
reviewed
May 11, 2026
| } | ||
|
|
||
| func port(p int) *intstr.IntOrString { | ||
| intstr := intstr.FromInt(p) |
Contributor
There was a problem hiding this comment.
I thought we can now get rid of this as we only support int ports now ?
Contributor
Author
There was a problem hiding this comment.
It's in a test and we use to create rules from Kubernetes resources (i.e. Service) for which we cannot change the type.
Contributor
|
Kubernetes actually defines a Maybe we should migrate to that ? |
majst01
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #73.
Noteworthy
Used AI-Tools ✨