fix: override missing CR-Foxboro stops#1010
Merged
Merged
Conversation
Contributor
Author
|
https://api-dev-green.mbtace.com/stops?filter[route]=CR-Foxboro is returning all the stops: {
"data": [
{
"attributes": {
"address": "100 Gaspee St, Providence, RI 02903",
"at_street": null,
"description": null,
"latitude": 41.829293,
"location_type": 1,
"longitude": -71.413301,
"municipality": "Providence",
"name": "Providence",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-NEC-1851",
"links": {
"self": "/stops/place-NEC-1851"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-NEC-1851"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-8",
"type": "zone"
}
}
},
"type": "stop"
},
{
"attributes": {
"address": "300 Pine St, Pawtucket, RI 02860",
"at_street": null,
"description": null,
"latitude": 41.878762,
"location_type": 1,
"longitude": -71.392,
"municipality": "Pawtucket",
"name": "Pawtucket/Central Falls",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-NEC-1891",
"links": {
"self": "/stops/place-NEC-1891"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-NEC-1891"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-8",
"type": "zone"
}
}
},
"type": "stop"
},
{
"attributes": {
"address": "133 South Main St, Attleboro, MA 02703",
"at_street": null,
"description": null,
"latitude": 41.940739,
"location_type": 1,
"longitude": -71.285094,
"municipality": "Attleboro",
"name": "Attleboro",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-NEC-1969",
"links": {
"self": "/stops/place-NEC-1969"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-NEC-1969"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-7",
"type": "zone"
}
}
},
"type": "stop"
},
{
"attributes": {
"address": "1 Crocker St, Mansfield, MA 02048",
"at_street": null,
"description": null,
"latitude": 42.032787,
"location_type": 1,
"longitude": -71.219917,
"municipality": "Mansfield",
"name": "Mansfield",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-NEC-2040",
"links": {
"self": "/stops/place-NEC-2040"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-NEC-2040"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-6",
"type": "zone"
}
}
},
"type": "stop"
},
{
"attributes": {
"address": "Gillette Stadium near Lots 3 and 4, Foxborough, MA 02035",
"at_street": null,
"description": null,
"latitude": 42.0951,
"location_type": 1,
"longitude": -71.26151,
"municipality": "Foxborough",
"name": "Foxboro",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-FS-0049",
"links": {
"self": "/stops/place-FS-0049"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-FS-0049"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-4",
"type": "zone"
}
}
},
"type": "stop"
},
{
"attributes": {
"address": "125 Allied Dr, Dedham, MA 02026",
"at_street": null,
"description": null,
"latitude": 42.227079,
"location_type": 1,
"longitude": -71.174254,
"municipality": "Dedham",
"name": "Dedham Corporate Center",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-FB-0118",
"links": {
"self": "/stops/place-FB-0118"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-FB-0118"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-2",
"type": "zone"
}
}
},
"type": "stop"
},
{
"attributes": {
"address": "145 Dartmouth St Boston, MA 02116",
"at_street": null,
"description": null,
"latitude": 42.34735,
"location_type": 1,
"longitude": -71.075727,
"municipality": "Boston",
"name": "Back Bay",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-bbsta",
"links": {
"self": "/stops/place-bbsta"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-bbsta"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-1A",
"type": "zone"
}
}
},
"type": "stop"
},
{
"attributes": {
"address": "700 Atlantic Ave, Boston, MA 02110",
"at_street": null,
"description": null,
"latitude": 42.352271,
"location_type": 1,
"longitude": -71.055242,
"municipality": "Boston",
"name": "South Station",
"on_street": null,
"platform_code": null,
"platform_name": null,
"vehicle_type": null,
"wheelchair_boarding": 1
},
"id": "place-sstat",
"links": {
"self": "/stops/place-sstat"
},
"relationships": {
"facilities": {
"links": {
"related": "/facilities/?filter[stop]=place-sstat"
}
},
"parent_station": {
"data": null
},
"zone": {
"data": {
"id": "CR-zone-1A",
"type": "zone"
}
}
},
"type": "stop"
}
],
"jsonapi": {
"version": "1.0"
}
} |
lemald
approved these changes
May 11, 2026
lemald
left a comment
lemald
left a comment
Member
There was a problem hiding this comment.
The code and resultant list of stops returned by the API look good to me, but did you ever get to the bottom of why we need the override in the first place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🍎🐛 API not returning all stops on CR-Foxboro
Adds an override for all the stops on the CR-Foxboro line to ensure that the South Station - Foxboro stops are included in the API response.