Encrypt the rust DB by default, to match EX#122
Merged
Conversation
andybalaam
approved these changes
Jul 15, 2024
andybalaam
left a comment
andybalaam
left a comment
Member
There was a problem hiding this comment.
Looks sensible if/when you can get the tests to pass
Member
Author
|
Blocked until performance on rust SDK improves, as it's spiking CI runtimes too much (3-5x). |
Member
|
Looks like we could have another go at this, now that SqliteStore supports |
Contributor
The builder in the bindings is getting updated in matrix-org/matrix-rust-sdk#6581. |
The `Passphrase` method got renamed to `SessionPassphrase`, and then removed altogether in matrix-org/matrix-rust-sdk@7c6ff51. The modern way is to make our own SqliteStoreBuilder, instead of having SessionPaths do it for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.