Skip to content

Add dev dependency group for easier local testing #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfisher87 merged 3 commits into from
Jun 2, 2026
Merged

Add dev dependency group for easier local testing #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6b6690
Add dev dependency group for easier local testing
mfisher87 Jun 2, 2026
b515ee3
Use dependency group in CI
mfisher87 Jun 2, 2026
0ad4da7
Move dependency groups to a more reasonable spot in project config
mfisher87 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@ jobs:

- name: "Install test and project dependencies"
run: |
# Project dependencies from pyproject.toml
# Project dependencies + test dependencies from pyproject.toml
# NOTE: Also builds viscm. How do we avoid this?
pip install .
pip install --group dev . ${{ matrix.pyqt-dependency }}
Copy link
Copy Markdown
Contributor

@stefanv stefanv Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do base dependencies always come along?

Copy link
Copy Markdown
Collaborator Author

@mfisher87 mfisher87 Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.e. these dependencies of viscm? Yeah, they come along with .!

dependencies = [
  "numpy ~=1.22",
  "matplotlib ~=3.5",
  "colorspacious ~=1.1",
  "scipy ~=1.8",
]

This reminds me I was just reading this comment you made over in a related issue :)


# Test dependencies
pip install pytest pytest-cov pytest-qt pytest-xvfb ${{ matrix.pyqt-dependency }}
# pytest-qt CI dependencies: https://pytest-qt.readthedocs.io/en/latest/troubleshooting.html#github-actions
sudo apt update
sudo apt install -y \
Expand All @@ -48,8 +46,5 @@ jobs:
# variable`, unless this variable is set:
MPLBACKEND: "Agg"

- name: "Install mypy"
run: "pip install mypy>=1.3"

- name: "Run typechecker"
run: "make typecheck"
9 changes: 9 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ dependencies = [
PySide = ["PySide6"]
PyQt = ["PyQt6"]

[dependency-groups]
dev = [
"mypy>=1.19.1",
"pytest>=8.4.2",
"pytest-cov>=7.1.0",
"pytest-qt>=4.5.0",
"pytest-xvfb>=3.1.1",
]

[project.urls]
repository = "https://github.com/matplotlib/viscm"
# documentation = "https://viscm.readthedocs.io"
Expand Down
Loading