Skip to content

Interface + base class for equation modulus#787

Merged
GiovanniCanali merged 6 commits intomathLab:0.3from
GiovanniCanali:equation_structure
Apr 20, 2026
Merged

Interface + base class for equation modulus#787
GiovanniCanali merged 6 commits intomathLab:0.3from
GiovanniCanali:equation_structure

Conversation

@GiovanniCanali
Copy link
Copy Markdown
Collaborator

@GiovanniCanali GiovanniCanali commented Apr 16, 2026 •
edited
Loading

Description

This PR fixes #784

In this PR, the following updates have been introduced:

  • equation Module:
    • Introduced a unified interface along with a base class structure for equations definition
    • Improved and expanded documentation for clarity and usability
    • Extended test coverage
  • equation/zoo Submodule:
    • Moved all specific equation implementations to the new equation/zoo submodule
    • Standardized naming of source and test files in accordance with PINA conventions

The core logic underpinning the entire equation module has remained unchanged from a user perspective.

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali requested a review from ndem0 April 16, 2026 14:21
@GiovanniCanali GiovanniCanali self-assigned this Apr 16, 2026
@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-fix Label for PR that needs modification 0.3 Related to 0.3 release labels Apr 16, 2026
@GiovanniCanali GiovanniCanali changed the title Equation structure Interface + base class for equation modulus Apr 16, 2026
@GiovanniCanali
Copy link
Copy Markdown
Collaborator Author

GiovanniCanali commented Apr 16, 2026

Waiting for PR #785 to be merged.

@GiovanniCanali GiovanniCanali marked this pull request as ready for review April 20, 2026 10:30
@GiovanniCanali GiovanniCanali requested review from a team and dario-coscia as code owners April 20, 2026 10:30
@GiovanniCanali GiovanniCanali added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Apr 20, 2026
@GiovanniCanali GiovanniCanali merged commit 4ad48a0 into mathLab:0.3 Apr 20, 2026
1 of 19 checks passed
@GiovanniCanali GiovanniCanali deleted the equation_structure branch April 20, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndem0 ndem0 Awaiting requested review from ndem0

@dario-coscia dario-coscia Awaiting requested review from dario-coscia dario-coscia is a code owner

Assignees

@GiovanniCanali GiovanniCanali

Labels

0.3 Related to 0.3 release enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GiovanniCanali