docs(arch): close out architecture review — resolution plan, ADR, guardrails, EchoesVault#121
Conversation
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rdrails, EchoesVault
Documentation closure for the go-llm-interactive-proxy architecture
de-slopification effort. Updates the spec docs and project knowledge
base to reflect the end state of the refactor.
- specs/go_llm_proxy_arch_review/resolution-plan.md: mark all phases
complete; rewrite the plan as the final closure record.
- specs/go_llm_proxy_arch_review/{architecture-review,findings-register,
source-index}.md: update to reflect deleted BuildExecutor wrappers,
moved standard_table.go, and the feature merge surface.
- docs/adr/0001-registry-driven-composition.md: registry is now the
registry type only; standard tables live in standardplugins; add a
dated update entry for the standardbundle/types.go/BuildExecutor
cleanup.
- docs/architecture-guardrails.md: document the bootstrap_plan.go
composition-root exemption, the role metadata in the hexagonal
baseline, and the standardplugins.DefaultWireModel rename.
- docs/architecture.md: note the MergeBundles/Append merge-surface
simplification.
- internal/plugins/features/README.md: wiring location corrected from
internal/pluginreg to internal/standardplugins.
- EchoesVault/pages/{plugin-system,testing-strategy}.md and
EchoesVault/daily/2026-07-08.md: compiled knowledge base updated.
Docs only; no code or test changes.
Note: this PR describes the end state of the cleanup, which is delivered
across #118 (runtimebundle invariant boundary), #119 (baseline role),
and #120 (merge surface). It should merge after those three to keep
docs and code consistent.
Co-authored-by: Cursor <cursoragent@cursor.com>
13beadf to
a91be6c
Compare
Append a daily-log entry recording the merge activity this session: architecture-review cleanup triaged into #117-#121, Dependabot bumps #122/#123 (with the aws-sdk-go-v2 go.sum conflict resolved by Dependabot auto-rebase), and 3 obsolete stashes dropped. No wiki page changes needed — pages are current; this is a log append only. Co-authored-by: Cursor <cursoragent@cursor.com>
Documentation closure for the architecture de-slopification effort. Updates the spec docs and project knowledge base to reflect the end state of the refactor.
What changed
specs/go_llm_proxy_arch_review/resolution-plan.md: mark all phases complete; rewrite the plan as the final closure record.specs/go_llm_proxy_arch_review/{architecture-review,findings-register,source-index}.md: update to reflect deletedBuildExecutorwrappers, the movedstandard_table.go, and the feature merge surface.docs/adr/0001-registry-driven-composition.md: registry is now the registry type only; standard tables live instandardplugins; add a dated update entry for thestandardbundle/types.go/BuildExecutorcleanup.docs/architecture-guardrails.md: document thebootstrap_plan.gocomposition-root exemption, therolemetadata in the hexagonal baseline, and thestandardplugins.DefaultWireModelrename.docs/architecture.md: note theMergeBundles/Appendmerge-surface simplification.internal/plugins/features/README.md: wiring location corrected frominternal/pluginregtointernal/standardplugins.EchoesVault/pages/{plugin-system,testing-strategy}.mdandEchoesVault/daily/2026-07-08.md: compiled knowledge base updated.Verification
go build ./...andgo test ./internal/archtest/...still pass (no test parses these docs' content — only comment/error-string references).Merge order
This PR describes the end state of the cleanup, delivered across #118 (runtimebundle invariant boundary), #119 (baseline
role), and #120 (merge surface). It should merge after those three to keep docs and code consistent.Final PR splitting the post-review cleanup changes on the local working tree.