Customisable FAB order/naming, conditional Reminders tab, and Settings reorg#83
Merged
Merged
Conversation
…nection The Chore page's version footer is redundant now that Settings > About already shows the version and What's New. Removed it there, and moved the Supabase connection entry to the penultimate slot in Settings since it's typically a one-time setup.
…tomisable The Reminders tab now only appears in the bottom bar while there are outstanding (non-archived) reminders. Added a Settings > Quick add button screen where the FAB's Task/Chore/Reminder menu can be reordered by drag handle or up/down buttons, and the reminders feature can be renamed to Reminders, Alarms, or Memos throughout the app. The FAB's button text is now just the short option name instead of the old "One-off reminder" / "Recurring chore" / "One-time task" phrasing. Moved AddMenuOption to data.model so it can be read from SettingsRepository alongside the new fabOrder/reminderLabel preferences.
The lambda-based Modifier.graphicsLayer used by the FAB order reorder list was imported from the wrong package, breaking compileDebugKotlin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddMenuOptionintodata.model(fromui.components) so the data layer'sSettingsRepositorycan store the ordering preference without a layering violation.Test plan
python3 a11y_check.pypasses (already run locally, clean).python3 check_changelog_fragment.pypasses (already run locally, clean).