feat(k8s-deploy): add image_project input for multi-repo apps#4
Merged
Conversation
update-app-manifest.sh already honours IMAGE_PROJECT (defaults to APP_NAME) so a repo whose image slug differs from the k8s app name can bump the right image ref. The action never passed it, so multi-repo apps could only ever bump the image matching APP_NAME. Falls back to app_name, so existing callers are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The `k8s-deploy` action passes only `APP_NAME`, `ENVIRONMENT`, `CLUSTER`, `BUILD_KEY` to the k8s-apps-config `update-app-manifest` pipeline.
But `update-app-manifest.sh` already supports `IMAGE_PROJECT` (defaults to `APP_NAME`) precisely so that a repo whose image slug differs from the k8s app name can bump the right image ref and look up the right build metadata - the documented `edr-dde` pattern (`APP_NAME=edr-dde`, `IMAGE_PROJECT=edr-dde-api`).
Because the action never sent it, multi-repo apps could only ever bump the image matching `APP_NAME` - any sibling repo would build an image that nothing consumes.
Change
Backwards compatible - callers that omit it get `IMAGE_PROJECT == APP_NAME`, i.e. the current behaviour.
Why now
Surfaced onboarding metadata-editor (MT-32): one k8s app fed by two repos - `metadata-editor` (web) and `metadata-editor-fastapi` (api). Without this, the FastAPI image builds and pushes to Harbor but its manifest ref can never be updated.