Skip to content

[GIT-227] fix: handle missing comment reaction in activity task #9175 #9298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharitSinghChauhan wants to merge 1 commit into
base: preview
Choose a base branch
from
+4 −1
Open

[GIT-227] fix: handle missing comment reaction in activity task #9175 #9298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/api/plane/bgtasks/issue_activities_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,7 +1149,7 @@ def create_comment_reaction_activity(
):
requested_data = json.loads(requested_data) if requested_data is not None else None
if requested_data and requested_data.get("reaction") is not None:
comment_reaction_id, comment_id = (
reaction_data = (
CommentReaction.objects.filter(
reaction=requested_data.get("reaction"),
project_id=project_id,
Expand All @@ -1158,6 +1158,9 @@ def create_comment_reaction_activity(
.values_list("id", "comment__id")
.first()
)
if reaction_data is None:
return
comment_reaction_id, comment_id = reaction_data
comment = IssueComment.objects.get(pk=comment_id, project_id=project_id)
if comment is not None and comment_reaction_id is not None and comment_id is not None:
issue_activities.append(
Expand Down