Skip to content

[GIT-260] fix(user): Profile cover image uses stale image after update #9285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codingwolf-at wants to merge 1 commit into
base: preview
Choose a base branch
from
+14 −4
Open

[GIT-260] fix(user): Profile cover image uses stale image after update #9285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/web/core/store/user/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class UserStore implements IUserStore {
* @returns {Promise<IUser>}
*/
updateCurrentUser = async (data: Partial<IUser>): Promise<IUser> => {
const currentUserData = this.data;
const currentUserData = cloneDeep(this.data);
try {
if (currentUserData) {
Object.keys(data).forEach((key: string) => {
Expand All @@ -162,6 +162,14 @@ export class UserStore implements IUserStore {
});
}
const user = await this.userService.updateUser(data);
if (user && this.data) {
runInAction(() => {
Object.keys(user).forEach((key: string) => {
const userKey: keyof IUser = key as keyof IUser;
if (this.data) set(this.data, userKey, user[userKey]);
});
});
}
return user;
} catch (error) {
if (currentUserData) {
Expand Down
8 changes: 5 additions & 3 deletions apps/web/helpers/cover-image.helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,13 @@ export const handleCoverImageChange = async (
}

if (analysis.needsUpload) {
await uploadCoverImage(newImage, uploadConfig);
return;
const assetUrl = await uploadCoverImage(newImage, uploadConfig);
// cover_image requires an absolute URL; cover_image_url is relative (matches GET /api/users/me/ format)
return { cover_image: getFileURL(assetUrl) || assetUrl, cover_image_url: assetUrl };
}

return { cover_image: newImage };
// cover_image requires an absolute URL; getFileURL converts relative paths from the Upload tab
return { cover_image: getFileURL(newImage) || newImage, cover_image_url: newImage };
};

/**
Expand Down
Loading