Skip to content

fix: Scope workspace user preference filter to current user #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okxint wants to merge 1 commit into
base: preview
Choose a base branch
from
+1 −1
Open

fix: Scope workspace user preference filter to current user #9261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/plane/app/views/workspace/user_preference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def patch(self, request, slug):
if not key:
continue

preference = WorkspaceUserPreference.objects.filter(key=key, workspace__slug=slug).first()
preference = WorkspaceUserPreference.objects.filter(key=key, workspace__slug=slug, user=request.user).first()

@sviat-barbutsa sviat-barbutsa Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Could you, please, add a regression test for the cross-user case?

The nuance: Before this change, two users in the same workspace with the same preference key could hit filter(key=key, workspace__slug=slug).first(), so PATCH might update another user’s preference row.

For this case will be helpful a test where user A and user B both have key="views" preferences, then user B patches sort_order or is_pinned, would lock in that only user B’s row changes.


if not preference:
continue
Expand Down
Loading