fix: support edge/serverless runtimes via axios adapter fallback (#31)#107
Open
CedricConday wants to merge 1 commit into
Open
fix: support edge/serverless runtimes via axios adapter fallback (#31)#107CedricConday wants to merge 1 commit into
CedricConday wants to merge 1 commit into
Conversation
…lerlite#31) The SDK hard-failed in runtimes that don't ship Node's `http` module (Vercel Edge, Cloudflare Workers, Next.js edge routes, Deno) with `AxiosError: There is no suitable adapter to dispatch the request`. axios >= 1.7 can be given an ordered list of adapters and picks the first one supported by the current runtime. Passing `["http", "xhr", "fetch"]` keeps Node on `http` and browsers on `xhr` (no behaviour change), while edge/serverless runtimes that ship neither transparently fall back to the universal `fetch` adapter. Adds a self-contained unit test (mocks axios, no network) and documents edge support in the README. Fixes mailerlite#31 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbUHs855FyBt2J7cG2Qmhh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SDK throws in runtimes that don't ship Node's
httpmodule — Vercel Edge Functions, Cloudflare Workers, Next.js edge routes, Deno — because axios can't find a usable adapter (reported in #31):Fix
axios ≥ 1.7 accepts an ordered list of adapters and selects the first one supported by the current runtime. All requests already funnel through a single
request()helper (src/utils/fetch.ts), so one change covers the whole SDK:http(no behaviour change; all recorded-tape tests stay green)xhrhttp/xhr) → transparently fall back to the universalfetchadapterNo new dependencies, no breaking changes, no major version needed.
axios@^1.15.0(already the declared dependency) ships thefetchadapter.Tests
src/utils/fetch.test.ts— a self-contained unit test (mocks axios, no network/API key) asserting the adapter fallback order.http).Docs
Added a short Edge & serverless runtimes note to the README.
Fixes #31
🤖 Generated with Claude Code
https://claude.ai/code/session_01DbUHs855FyBt2J7cG2Qmhh