fix: accept the ephemeral oracle discriminator for the price feed#112
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
decodeOraclePricevalidates the price-feed account's 8-byte discriminator before readingPriceUpdateV2fields at fixed offsets. It only accepted the canonical PythPriceUpdateV2discriminator (sha256("account:PriceUpdateV2")), but the SOL/USD feed the demo reads (ENYwebBThHzmzwPLAQvCucUTsjyfBSZdD9ViXksS4jPu) is served by MagicBlock's ephemeral oracle (ownerPriCems5tHihc6UDXDjzjeawomAwBduWMGAi8ZUjppd), which mirrors thePriceUpdateV2field layout but uses its own discriminator. So every price read threwOracle account is not a Pyth PriceUpdateV2 account, breaking the live price display and the whole flow.Why
The discriminator validation was added in #111 (a CodeRabbit suggestion) assuming a canonical Pyth account. This is a regression from that PR.
Fix
Accept the ephemeral oracle's discriminator (
[234, 161, 14, 36, 172, 239, 15, 232]) in addition to the canonical PythPriceUpdateV2one, so both a local/devnet ephemeral oracle and a real Pyth feed decode. Still fails clearly on an unrecognized account.Testing
tsc --noEmitandvite buildpass.