Skip to content

Exclude command output panels from log find#33

Merged
lynnswap merged 2 commits into
mainfrom
codex/exclude-command-output-from-log-search
Jun 9, 2026
Merged

Exclude command output panels from log find#33
lynnswap merged 2 commits into
mainfrom
codex/exclude-command-output-from-log-search

Conversation

@lynnswap

@lynnswap lynnswap commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Purpose

Exclude command output panel contents from the log view find target so searches only match visible log text, while keeping command output titles searchable.

Changes

  • Removed command output panel supplemental text from the log finder mapping.
  • Kept active find snapshots mapped during command output panel replacements and streaming updates.
  • Updated regression coverage for hidden command output text, visible command titles, and active find snapshot mapping.

Testing

  • swift test --build-system swiftbuild --no-parallel --filter commandOutputRendersCollapsedTextKitPanelAndExpandsInline
  • swift test --build-system swiftbuild --no-parallel --filter expandingCommandOutputKeepsPanelTextOutOfActiveFindSnapshot
  • swift test --build-system swiftbuild --no-parallel --filter collapsedCommandOutputFinderSupplementSignatureIgnoresHiddenOutputContent
  • swift test --build-system swiftbuild --no-parallel
  • xcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO
  • codex-review --base main clean, findingCount: 0

@lynnswap lynnswap merged commit ab6f8ce into main Jun 9, 2026
1 check passed
@lynnswap lynnswap deleted the codex/exclude-command-output-from-log-search branch June 9, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant