Default migrationStep to latest so fresh installs skip migrations#631
Merged
marionbarker merged 1 commit intodevfrom May 4, 2026
Merged
Default migrationStep to latest so fresh installs skip migrations#631marionbarker merged 1 commit intodevfrom
marionbarker merged 1 commit intodevfrom
Conversation
Previously migrationStep defaulted to 0, forcing every fresh install to iterate through every migration. Set the default to the latest step (7) and update other StorageValue defaults to match the post-migration final state on a fresh install: - snoozerPosition: .menu -> .position3 - nightscoutPosition: .position3 -> .position4 - remotePosition: .position4 -> .menu - hasSeenFatProteinOrderChange: false -> true Add reminder comments at the migrationStep declaration and at the runMigrationsIfNeeded() block so future authors bump the default and update affected defaults whenever a new step is added.
marionbarker
approved these changes
May 4, 2026
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approve from code review and test build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously
migrationStepdefaulted to0, forcing every fresh install to iterate through every migration step. The migrations are designed for upgraders carrying legacy state — for a brand-new install they're all no-ops or set values that the static defaults could just hold directly.This change sets the default
migrationStepto the current latest step (7) and updates the otherStorageValuedefaults so a fresh install ends up in the same state as a user who ran every migration:snoozerPosition:.menu→.position3nightscoutPosition:.position3→.position4remotePosition:.position4→.menuhasSeenFatProteinOrderChange:false→true(matches what step 4 sets for fresh installs via!isExistingUser)alarmsPosition(.position2) andhomePosition(.position1) already matched the post-migration state.Reminder comments are added at the
migrationStepdeclaration and at therunMigrationsIfNeeded()block so future authors remember to bump the default and update affected defaults whenever a new migration step is added.Existing users are unaffected: they have a stored
migrationStepvalue and continue to run only the steps they haven't yet executed.