Fix -Wchanges-meaning errors from newer GCC#1095
Open
Conversation
GCC 15 treats -Wchanges-meaning as an error, which fires when a struct member declaration shadows its own type name (e.g. `Format Format;` or `std::unique_ptr<Fence> Fence;`). CMake selects GCC as the default compiler on Linux when both GCC and Clang are installed, so the OffloadTest library fails to build on distros shipping GCC 15 (e.g. Arch Linux). The shadowing was introduced by: - PR llvm#1020 (Introduce a new Texture type): `Format Format;` in TextureCreateDesc - PR llvm#1007 (Implement an abstract Fence type): `unique_ptr<Fence> Fence;` in InvocationState (all backends) Rename the offending members to break the shadowing: - TextureCreateDesc::Format -> TextureCreateDesc::Fmt - InvocationState::Fence -> InvocationState::CompletionFence (all backends) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
s-perron
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 treats
-Wchanges-meaningas an error, which fires when a struct member declaration shadows its own type name (e.g.Format Format;orstd::unique_ptr<Fence> Fence;). CMake selects GCC as the default compiler on Linux when both GCC and Clang are installed, so theOffloadTestlibrary fails to build on distros shipping GCC 15 (e.g. Arch Linux).The shadowing was introduced by:
Texturetype with DX,VK,MTL implementations. #1020 (Introduce a newTexturetype):Format Format;inTextureCreateDescFencetype):unique_ptr<Fence> Fence;inInvocationState(all backends)Rename the offending members to break the shadowing:
TextureCreateDesc::Format->TextureCreateDesc::FmtInvocationState::Fence->InvocationState::CompletionFence(all backends)