test(sidebar): cover delegate sizeHint and bookmark/notes widgets#305
Merged
deepin-bot[bot] merged 1 commit intoJul 22, 2026
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @pengfeixx, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
pengfeixx
force-pushed
the
feat/cov-sidebar-delegates
branch
from
July 22, 2026 01:21
b07a57c to
b6b9111
Compare
Extend ut_bookmarkwidget fixing duplicate testnextPage. Extend ut_noteswidget with deleteNoteItem and pageUp. Add sizeHint tests to ut_notesdelegate, ut_searchresdelegate, ut_thumbnaildelegate. 修复 ut_bookmarkwidget 中重复的 testnextPage。扩充 ut_noteswidget 覆盖 deleteNoteItem 和 pageUp。为三个 delegate 测试补充 sizeHint 用例。 Log: 新增 sidebar delegate/widget 测试覆盖 Influence: 覆盖书签、注释、搜索结果代理的绘制与尺寸计算。
pengfeixx
force-pushed
the
feat/cov-sidebar-delegates
branch
from
July 22, 2026 03:09
b6b9111 to
9896609
Compare
lzwind
approved these changes
Jul 22, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend ut_bookmarkwidget fixing duplicate testnextPage. Extend ut_noteswidget with deleteNoteItem and pageUp. Add sizeHint tests to ut_notesdelegate, ut_searchresdelegate, ut_thumbnaildelegate.
修复 ut_bookmarkwidget 中重复的 testnextPage。扩充
ut_noteswidget 覆盖 deleteNoteItem 和 pageUp。为三个 delegate 测试补充 sizeHint 用例。
Log: 新增 sidebar delegate/widget 测试覆盖
Influence: 覆盖书签、注释、搜索结果代理的绘制与尺寸计算。