fix(gui): OAuth manual redirect URL / code paste fallback#132
Merged
lidge-jun merged 1 commit intoJul 15, 2026
Merged
Conversation
Wire GUI login to the same onManualCodeInput path the CLI uses so xAI (and other browser OAuth providers) can finish when the loopback callback is unreachable. Adds POST /api/oauth/login/code, dashboard paste UI, and focused regression tests. Closes lidge-jun#131
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
|
Merged into dev and released in v2.7.19 — thanks for fixing #131! Stacked hardening on top (06ee963): pasted redirect URLs/query strings now require a matching |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuthCallbackFlowproviders) could not finish when the browser failed to hit the loopback callback — CLI already had paste fallback viaonManualCodeInput, GUI did not.startLoginFlowto accept a pasted redirect URL or authorization code throughsubmitManualLoginCode, exposePOST /api/oauth/login/code, and show paste UI on Providers + Add Provider while login is waiting.Closes #131
Verification
bun test tests/oauth-manual-code.test.tsbun test tests/oauth-status-privacy.test.ts tests/kiro-oauth.test.tsbun x tsc --noEmit(root +gui/)bun run build:guibun run src/cli/index.ts start→ dashboard served after GUI build; paste field appears during OAuth waitChecklist