Fix macOS save state crash in dual-core mode#428
Open
ryanmagoon wants to merge 1 commit into
Open
Conversation
In dual-core mode, retro_serialize and retro_unserialize queue DoState to the CPU thread via RunOnCPUThread. The CPU thread does not have the frontend's GL context current, so any GL calls during DoState segfault. Temporarily declare the calling thread as the CPU thread so DoState runs inline where the GL context is valid. Tested on macOS arm64 with a third-party libretro frontend using an offscreen CGL context.
ryanmagoon
changed the title
7 tasks
|
@warmenhoven are you able to test this please? as I don't have a mac |
|
It seems that this crash while loading states with dual core mode on is also happening in Android. |
|
Check if this applied on top makes this PR safer 0001-Use-CPUThreadGuard-for-save-state-instead-of-declari.patch |
|
@LibretroAdmin Just tested this on linux, doesn't break anything so I'm happy for it to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dual-core mode on macOS,
retro_serializeandretro_unserializequeueDoStateto the CPU thread viaRunOnCPUThread. Frontends using an offscreen CGL context (no window-backed default framebuffer) set the GL context current on the calling thread, not the CPU thread. Any GL calls duringDoStateon the CPU thread segfault.This temporarily declares the calling thread as the CPU thread so
DoStateruns inline where the GL context is valid.Only tested on macOS arm64 with my own libretro frontend using an offscreen CGL context.