add poll notification support#140
Merged
Merged
Conversation
obbardc
force-pushed
the
wip/obbardc/add-notify-poll
branch
from
de00d33 to
66c617d
Compare
Nikratio
reviewed
May 5, 2026
Nikratio
reviewed
May 5, 2026
Nikratio
reviewed
May 5, 2026
Contributor
|
Thanks for the MR! I only just replied on the issue tracker :-). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes libfuse low-level poll(2) readiness support through pyfuse3, allowing filesystems to implement Operations.poll() and later wake blocked poll/select/epoll waiters via notify_poll().
Changes:
- Wire up the libfuse low-level
pollcallback and reply path (fuse_ops.poll→fuse_poll→Operations.poll→fuse_reply_poll). - Introduce a
PollHandleopaque type plusnotify_poll(handle)to deliver readiness notifications. - Add an integration test filesystem and test case covering poll notification behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/test_fs.py |
Adds a pollable test file and an integration test validating wakeup via notify_poll. |
src/pyfuse3/internal.pxi |
Registers the new low-level poll handler in fuse_lowlevel_ops. |
src/pyfuse3/handlers.pxi |
Implements fuse_poll/fuse_poll_async bridging to Operations.poll and replies with fuse_reply_poll. |
src/pyfuse3/_pyfuse3.py |
Adds the Operations.poll() API and its documentation. |
src/pyfuse3/__init__.pyx |
Adds PollHandle and the notify_poll() API. |
src/pyfuse3/__init__.pyi |
Updates typing stubs for PollHandle and notify_poll(). |
Include/fuse_lowlevel.pxd |
Declares low-level poll op, fuse_reply_poll, and fuse_lowlevel_notify_poll. |
Include/fuse_common.pxd |
Declares fuse_pollhandle and fuse_pollhandle_destroy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nikratio
reviewed
May 5, 2026
Nikratio
requested changes
May 6, 2026
Nikratio
reviewed
May 8, 2026
Nikratio
approved these changes
May 8, 2026
Contributor
Nikratio
left a comment
Nikratio
left a comment
There was a problem hiding this comment.
Just one small idea to make it even nicer, but it's good to merge with and without that.
Contributor
Author
|
@Nikratio thanks for your help with this one! I will split this into a few commits once you give me all OK. |
Contributor
|
I think this can all go in one commit. |
Nikratio
approved these changes
May 8, 2026
Expose libfuse low-level poll support through pyfuse3 so that filesystems can implement readiness notifications for poll(2), select(2) and epoll_wait(2). Add bindings for struct fuse_pollhandle, fuse_reply_poll(), fuse_lowlevel_notify_poll() and fuse_pollhandle_destroy(). Introduce a Python PollHandle wrapper with a notify() method to allow a filesystem to retain the poll handle provided by Operations.poll() and notify it later when readiness changes. Wire the low-level FUSE poll callback into Operations.poll(), returning the current readiness mask to the kernel. The default implementation continues to raise -ENOSYS so existing filesystems keep the previous fallback behaviour unless they opt-in. This is needed by filesystems that emulate pollable kernel interfaces, such as sysfs GPIO value files, where edge events must wake userspace processes waiting for POLLPRI. Fixes: libfuse#139 Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
obbardc
force-pushed
the
wip/obbardc/add-notify-poll
branch
from
f7f9a5e to
f15e109
Compare
Contributor
Author
|
Thanks, squashed into a single commit. Once merged, is it possible to please release a new version soonish? |
Contributor
Tried today, but run into some unexpected issues with generating the documentation ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose libfuse low-level poll support through pyfuse3.