Remove leave-aware dispatcher continuation#1907
Closed
Th0rgal wants to merge 4 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
| \n### CI Failure Hints\n\nFailed jobs: `checks`\n\nCopy-paste local triage:\n```bash\nmake check\nlake build\nFOUNDRY_PROFILE=difftest forge test -vv\n``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LeaveAwareCallDispatcherContinuationfrom EndToEnd.hContpremise from the E2/E4/E6 and F2/F4/F6 success bridge wrappers.Stacked on #1906.
Verification
lake env lean --stdinpassed on the stacked branch.lake build Compiler.Proofs.EndToEndNote
Medium Risk
Changes the generated deploy and runtime prologue to
mstore(0x40, 128), which can affect all contracts that rely on free-memory-based ABI encoding/event emission. Risk is moderate because it alters low-level EVM memory initialization but is localized and conventional.Overview
Adds an explicit
initFreeMemoryPointerYul statement that sets the Solidity free memory pointer (mstore(0x40, 128)).Injects this initialization into all generated outputs: before the runtime dispatcher switch, in the emit-options runtime path, and at the start of deploy code (ahead of value guards/mapping helpers/constructor code).
Reviewed by Cursor Bugbot for commit 7d47813. Bugbot is set up for automated code reviews on this repo. Configure here.