updates for dplms, move cuts out of pygama to script#31
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates HPGe DSP parameter-generation scripts, including changes to how optimiser/cut-related artifacts are produced and serialized.
Changes:
- Update
eoptoptimiser pickle output structure (wrap under an"eopt"key). - Rework
dplmsbaseline selection to run a DSP pass and apply generated quality cuts before computing DPLMS coefficients.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/legenddataflowscripts/par/geds/dsp/eopt.py |
Adjusts how optimiser objects are serialized to the --qbb-grid-path pickle output. |
src/legenddataflowscripts/par/geds/dsp/dplms.py |
Adds a DSP+cuts preprocessing step for baseline FFT events and refactors plotting behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/legend-exp/legend-dataflow-scripts/sessions/cebc3462-f6e5-4ec3-ad9d-ab40fad5ab54 Co-authored-by: ggmarshall <72088559+ggmarshall@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.