Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 added ed25519 support in OpenSSL:
https://www.php.net/manual/en/migration84.new-features.php#migration84.new-features.openssl
openssl_get_curve_names()does not returned25519, so the previous curve-based check did not work.I changed the detection to check if
OPENSSL_KEYTYPE_ED25519is defined instead.There was also an issue in the verify logic: for Ed25519,
openssl_verify()must use algorithm0, notOPENSSL_ALGO_SHA256.At the moment, I am using
openssl_pkey_get_details()to determine the key type. I am not sure whether there is a better way to detect this without callingopenssl_pkey_get_details(), but this works for now.