fix: center event image and fix Join Now button navigation #7623#7633
Open
AnkitRewar11 wants to merge 1 commit intolayer5io:masterfrom
Open
fix: center event image and fix Join Now button navigation #7623#7633AnkitRewar11 wants to merge 1 commit intolayer5io:masterfrom
AnkitRewar11 wants to merge 1 commit intolayer5io:masterfrom
Conversation
|
🚀 Preview deployment: https://layer5io.github.io/layer5/pr-preview/pr-7633/ |
rishiraj38
reviewed
Apr 15, 2026
Member
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
Please attach a Before and After image for better reference.
Contributor
Author
|
Before after Screen.Recording.2026-04-16.001011.mp4@rishiraj38 here are the before and after results, along with a video recording after the changes. |
Contributor
Author
|
@rishiraj38 These changes have now been applied to the other slide images as well, which weren’t working before. |
AnkitRewar11
force-pushed
the
fix/events-image-alignment-v2
branch
from
a90b873 to
00bed1c
Compare
Contributor
Author
@rishiraj38 all set, please take a look again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7623
The Events section on desktop had three issues:
What was wrong and what I fixed
src/components/UpcomingEventCard/EventCard.style.jsThe image container was using
object-fit: containwhich shrinks the image to fit inside the box, leaving black/empty gaps around it. I changed it toobject-fit: coverso the image fills the container properly. I also added flexbox centering (display: flex,align-items: center,justify-content: center) andoverflow: hiddento make sure the image stays centered and does not overflow outside the container.src/components/UpcomingEventCard/index.jsThe "Join Now" button had
$url={item.frontmatter.eurl}which wasnullorundefinedfor events that don't have an external registration link. This caused the button to render without anyhref, so clicking it did nothing. I added a fallback so if no external URL exists, it redirects to the internal event page instead. I also fixed$external={true}which was hardcoded — now it is$external={!!item.frontmatter.eurl}so only events with an external URL open in a new tab.Notes for Reviewers
Only 2 files changed, 1 clean commit. The CI
build:previewfailure is a pre-existing issue in the repo and is not related to these changes.Signed commits