fix: remediate high & critical vulnerabilities in example lockfiles#400
Closed
pkaeding wants to merge 1 commit into
Closed
fix: remediate high & critical vulnerabilities in example lockfiles#400pkaeding wants to merge 1 commit into
pkaeding wants to merge 1 commit into
Conversation
Co-Authored-By: Patrick Kaeding <patrick@kaeding.name>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
#401 is more comprehensive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Remediates 60 of 62 open high/critical Dependabot alerts, all originating from stale
examples/hoc/yarn.lockandexamples/async-provider/yarn.lock.Describe the solution you've provided
express^4.17.3→^4.21.0,lodash^4.17.21→^4.18.0resolutionsto force patched versions of vulnerable transitive deps (elliptic, cipher-base, sha.js, pbkdf2, node-forge, path-to-regexp, serialize-javascript, koa, ws, braces, json5, minimatch, flatted, tmp, ansi-regex, @babel/plugin-transform-modules-systemjs, body-parser, webpack-dev-middleware, cross-spawn, trim-newlines, http-proxy-middleware, ansi-html)Remaining (unfixable): 2
ipSSRF alerts (1 per lockfile) — no patch exists for theippackage. These come fromuniversal-hot-reload > webpack-dev-server > ip.Describe alternatives you've considered
Removing the example projects entirely, or upgrading their build toolchain from webpack 4 to webpack 5+. Both would be more disruptive than targeted resolutions.
Additional context
The main
package-lock.jsonhas zero high/critical vulnerabilities. All alerts were isolated to the example project lockfiles. Build, lint, and all 93 tests pass on the main SDK — only example lockfiles changed.Link to Devin session: https://app.devin.ai/sessions/f782088a3883446e8bb7b049e5631747
Requested by: @pkaeding