ci: add permissions to publish caller job and upgrade release-please-action to v5#19
Open
kinyoklion wants to merge 1 commit into
Open
ci: add permissions to publish caller job and upgrade release-please-action to v5#19kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
…action to v5 The release-please workflow fails with startup_failure because the caller job invoking publish.yml does not declare explicit permissions. Also upgrades release-please-action from v4 to v5. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Release Please
startup_failureby adding explicitpermissionsto thepublishcaller job. Also upgrades release-please-action from v4 to v5.Review & Testing Checklist for Human
Notes
Same fix pattern as dotnet-core PR #241. The publish caller job needs explicit permissions because publish.yml declares permissions that exceed the restricted org defaults.
Link to Devin session: https://app.devin.ai/sessions/54e32482848742c19ebf9c374efdc833
Requested by: @kinyoklion
Note
Low Risk
Workflow-only changes; main risk is misconfigured GitHub Actions permissions or action upgrade causing the release/publish pipeline to fail.
Overview
Upgrades
googleapis/release-please-actioninrelease-please.ymlfrom v4 to v5.Adds explicit
permissionsto thepublishcaller job (includingattestations: write) so it can invokepublish.ymlwithout permission-related startup failures under restricted org defaults.Reviewed by Cursor Bugbot for commit 0ff5510. Bugbot is set up for automated code reviews on this repo. Configure here.