refactor: replace bigSegmentStatus string with EvaluationReason::BigSegmentsStatus enum#549
Open
beekld wants to merge 5 commits into
Open
refactor: replace bigSegmentStatus string with EvaluationReason::BigSegmentsStatus enum#549beekld wants to merge 5 commits into
beekld wants to merge 5 commits into
Conversation
…egmentsStatus enum
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c43f046. Configure here.
kinyoklion
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replace bigSegmentStatus string with typed enum
Renames the (currently unused-but-public)
EvaluationReasonBig Segments field from singularbigSegmentStatusto spec-compliant pluralbigSegmentsStatus, and introduces a typed enum to replace itsstd::optional<std::string>representation. No evaluator behavior change in this PR — the field still has no in-tree writer; that lands in SDK-2366-2.What's in
EvaluationReason::BigSegmentsStatus(kHealthy/kStale/kNotConfigured/kStoreError), mirroringKindandErrorKind.friend std::ostream& operator<<for the enum.tag_invokepair in the JSON serializer (mirrorsKindandErrorKind).Breaking changes
EvaluationReason::BigSegmentStatus()renamed toBigSegmentsStatus()and now returnsstd::optional<EvaluationReason::BigSegmentsStatus>instead ofstd::optional<std::string>.EvaluationReasonconstructor's last parameter changes type to match."bigSegmentStatus"renamed to"bigSegmentsStatus".The field has never had an in-tree writer and only ever returned an empty optional / been absent from JSON, so no caller could have depended on a value.
Note
Medium Risk
Public API and JSON field renames are breaking for C++/serialization consumers, though the field was previously unused at runtime; enum stability matters for the C API.
Overview
Big Segments status on
EvaluationReasonis now a typed enum instead of an optional string, with the wire/API name aligned to spec asbigSegmentsStatus.The PR adds
EvaluationReason::BigSegmentsStatus(kNone,kHealthy,kStale,kNotConfigured,kStoreError) with C-API-stable numeric values, a primaryBigSegmentsStatus()accessor, andostream/ JSONtag_invokesupport (fieldbigSegmentsStatuson serialize/deserialize). Factories and equality/<<now use the enum; absent status iskNoneand is omitted from JSON.Breaking but transitional: the old
BigSegmentStatus()string getter and string-typed constructor remain as deprecated shims. Call sites and tests are updated to passBigSegmentsStatus::kNonewhere appropriate. No evaluator logic changes in this PR—the status still has no in-tree writer.Reviewed by Cursor Bugbot for commit ae98702. Bugbot is set up for automated code reviews on this repo. Configure here.