fix: Specify mandatory version property for Kubescape action in examples#74
Closed
esafak wants to merge 1 commit into
Closed
fix: Specify mandatory version property for Kubescape action in examples#74esafak wants to merge 1 commit into
esafak wants to merge 1 commit into
Conversation
…les and fix typo * Add `version: latest` input to `.github/workflows/example-scan.yaml`. * Add `version: latest` input to `.github/workflows/example-scan-image.yaml`. * Add `version: latest` input to `.github/workflows/example-fix-commit.yaml`. * Add `version: latest` input to `.github/workflows/example-fix-pr-review.yaml`. * Correct typo "Scannign" to "Scanning" in `entrypoint.sh`. Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Contributor
Contributor
|
@yugal07 do you want to take a look? |
Contributor
|
Yes let me check. Thanks @matthyx |
Contributor
|
Hi @esafak, I took a look, both changes here have since been applied to main: @matthyx's a04da8d added default: latest to the version input in action.yml, so existing workflows (and the examples) no longer break without an explicit version:. The "Scannign" → "Scanning" typo in entrypoint.sh was fixed in c89ccd3 on the same day. So I think this PR can be closed. The only remaining bit of value would be explicitly setting version: latest in the example workflows as documentation, happy to open a tiny follow-up PR for that if @matthyx thinks it's worth it. Otherwise, I think we can close this out? Thanks for the contribution |
Contributor
|
yeah @yugal07 just add a small doc related PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#72 broke the existing workflows because we neglected to update them to specify the new, mandatory
versionproperty.This PR will...
version: latestinput to.github/workflows/example-scan.yaml.version: latestinput to.github/workflows/example-scan-image.yaml.version: latestinput to.github/workflows/example-fix-commit.yaml.version: latestinput to.github/workflows/example-fix-pr-review.yaml.entrypoint.sh.Notes
Since this is a breaking change, I suggest versioning and updating documentation accordingly.