⚡ Bolt: [performance improvement] Defer PathBuf allocations during Tarjan DFS traversal

[bashandbone]

💡 What: Defer PathBuf heap allocations during DAG traversals in Tarjan's algorithm by reusing a single allocated PathBuf for map insertions and updating RapidMap get() and get_mut() calls to utilize borrowed slice references (&Path) directly.

🎯 Why: During graph traversals (especially tarjan_dfs inside crates/flow/src/incremental/invalidation.rs), calling .to_path_buf() on the path v solely to query state.indices and state.lowlinks maps causes an unnecessary heap allocation and copy (O(E)) every time a path is looked up.

📊 Impact: Reduces heap allocation churn proportionally to the number of nodes/edges during dependency graph invalidation/strongly connected component detection.

🔬 Measurement: Check the impact and verify functional equivalence by running cargo test -p thread-flow --test invalidation_tests and observing potential speedups during memory-bound parsing load tests.

---

PR created automatically by Jules for task 11639498753115775058 started by @bashandbone

Summary by Sourcery

Improve path handling performance in Tarjan DFS traversal and apply minor readability/style cleanups across AST and rule engine modules.

Enhancements:

• Reduce heap allocation overhead in Tarjan DFS by avoiding repeated PathBuf creations on map lookups and reusing a single buffer per traversal.
• Reformat string conversion, assertion, and lock-handling code paths for improved readability without changing behavior.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

Optimizes Tarjan DFS path handling by eliminating repeated PathBuf allocations via borrowed Path lookups, plus minor formatting/clarity cleanups in AST and rule engine code.

Sequence diagram for optimized Tarjan DFS path handling

sequenceDiagram
    participant InvalidationDetector
    participant TarjanState
    participant Indices as RapidMapIndices
    participant Lowlinks as RapidMapLowlinks
    participant Graph

    InvalidationDetector->>TarjanState: tarjan_dfs(v, state, sccs)
    Note over InvalidationDetector,TarjanState: Initialize node v
    InvalidationDetector->>InvalidationDetector: v_buf = v.to_path_buf()
    InvalidationDetector->>Indices: insert(v_buf.clone(), index)
    InvalidationDetector->>Lowlinks: insert(v_buf.clone(), index)
    InvalidationDetector->>TarjanState: stack.push(v_buf.clone())
    InvalidationDetector->>TarjanState: on_stack.insert(v_buf)

    InvalidationDetector->>Graph: get_dependencies(v)
    Graph-->>InvalidationDetector: dependencies

    loop for each dep in dependencies
        alt dep in indices
            Lowlinks-->>InvalidationDetector: get(dep)
            Lowlinks-->>InvalidationDetector: get_mut(v)
            InvalidationDetector->>Lowlinks: update lowlink for v
        else dep in on_stack
            Indices-->>InvalidationDetector: get(dep)
            Lowlinks-->>InvalidationDetector: get_mut(v)
            InvalidationDetector->>Lowlinks: update lowlink for v
        end
    end

    Note over InvalidationDetector,TarjanState: Root check uses borrowed &Path
    Indices-->>InvalidationDetector: get(v)
    Lowlinks-->>InvalidationDetector: get(v)
    InvalidationDetector->>TarjanState: possibly emit SCC

Loading

File-Level Changes

Change	Details	Files
Optimize Tarjan DFS to avoid repeated PathBuf allocations and use borrowed Path keys when accessing maps.	Introduce a single PathBuf (v_buf) per DFS call, cloning it only for map insertions and stack storage instead of recreating from &Path each time. Update indices and lowlinks initialization to insert cloned v_buf values for each map and stack/on_stack entry. Change RapidMap lowlinks and indices lookups from using &v.to_path_buf() to directly using &Path (v) in get and get_mut calls, avoiding temporary allocations. Ensure lowlink computations and root-node checks now operate exclusively on borrowed Path keys for map access.	crates/flow/src/incremental/invalidation.rs
Refactor string and rule-engine helper code for style/clarity without changing behavior.	Reformat a String::from_utf8 / from_utf8_lossy fallback expression into a single chained expression for readability. Reformat a test assertion on Tree-sitter parse trees into multi-line assert_eq! for clearer diffs. Reformat Rule::Pattern defined_vars collection into a multi-line iterator chain for consistency with style. Simplify Registration::read by collapsing the read/unwrap_or_else/clone call into a single expression line.	crates/ast-engine/src/tree_sitter/mod.rs crates/rule-engine/src/rule/mod.rs crates/rule-engine/src/rule/referent_rule.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In tarjan_dfs, we still allocate multiple PathBufs for the same path via v.to_path_buf() and several .clone() calls; consider restructuring the state (e.g., storing &Path/borrowed keys where possible or inserting owned keys with PathBuf::from(v) directly without an intermediate v_buf that is repeatedly cloned) to minimize both the number of allocations and clones per node.
• The // Bolt: defer PathBuf allocations during traversal by reusing a single allocation comment in tarjan_dfs no longer accurately reflects the implementation (we’re not actually reusing a single PathBuf as a shared key); consider updating or removing it to avoid confusion about the optimization being performed.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `tarjan_dfs`, we still allocate multiple `PathBuf`s for the same path via `v.to_path_buf()` and several `.clone()` calls; consider restructuring the state (e.g., storing `&Path`/borrowed keys where possible or inserting owned keys with `PathBuf::from(v)` directly without an intermediate `v_buf` that is repeatedly cloned) to minimize both the number of allocations and clones per node.
- The `// Bolt: defer PathBuf allocations during traversal by reusing a single allocation` comment in `tarjan_dfs` no longer accurately reflects the implementation (we’re not actually reusing a single `PathBuf` as a shared key); consider updating or removing it to avoid confusion about the optimization being performed.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

This PR reduces unnecessary PathBuf heap allocations during Tarjan DFS traversal in the incremental invalidation detector by switching map lookups to borrowed &Path keys, and includes a few small formatting/readability refactors in rule-engine and ast-engine modules.

Changes:

• Avoid repeated v.to_path_buf() allocations in Tarjan DFS by using borrowed &Path for RapidMap get/get_mut calls.
• Minor formatting/readability tweaks in rule registration/map read code and defined_vars collection.
• Minor formatting tweaks in tree-sitter edit handling and a test assertion.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
crates/flow/src/incremental/invalidation.rs	Updates Tarjan DFS to use borrowed &Path for map lookups, reducing allocation churn during traversal.
crates/rule-engine/src/rule/referent_rule.rs	Refactors RwLock read/clone expression formatting (no behavior change).
crates/rule-engine/src/rule/mod.rs	Reformats defined_vars mapping/collection for readability (no behavior change).
crates/ast-engine/src/tree_sitter/mod.rs	Minor formatting/readability changes in UTF-8 conversion and a test assertion.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.