Improve accessibility of list items for Talkback screen reader#2141
Open
keymapper-ai wants to merge 1 commit into
Open
Improve accessibility of list items for Talkback screen reader#2141keymapper-ai wants to merge 1 commit into
keymapper-ai wants to merge 1 commit into
Conversation
Add contentDescriptions to drag handle icons using the existing
drag_handle_for string resource, and add custom accessibility actions
("Move up", "Move down") to trigger key and action list items so TalkBack
users can reorder items without needing to perform drag gestures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1369
Summary
contentDescription = null. They now use the existingdrag_handle_forstring resource (e.g. "Drag handle for Volume Up") so TalkBack announces them meaningfully.onMoveUpandonMoveDownparameters toTriggerKeyListItemandActionListItem. When reordering is enabled, "Move up" and "Move down" custom accessibility actions are registered viaModifier.semantics { customActions = ... }so TalkBack users can reorder items without performing drag gestures. The first item only shows "Move down" and the last item only shows "Move up".accessibility_action_move_up("Move up") andaccessibility_action_move_down("Move down") added tostrings.xml.Files changed
base/src/main/res/values/strings.xml— new string resourcesbase/src/main/java/.../trigger/TriggerKeyListItem.kt— drag handle label + move up/down accessibility actionsbase/src/main/java/.../actions/ActionListItem.kt— drag handle label + move up/down accessibility actionsbase/src/main/java/.../trigger/BaseTriggerScreen.kt— passes move callbacks toTriggerKeyListItembase/src/main/java/.../actions/ActionsScreen.kt— passes move callbacks toActionListItemCHANGELOG.md— updatedKnown limitations / areas for human review
SortBottomSheetContent.ktdrag handle already useddrag_handle_forcorrectly and was not changed.onMovesemantics are consistent with how the ViewModel handles reordering.Generated by Claude Code