change(web): support multi-token suggestion similarity 🚂 🔪#15952
Open
jahorton wants to merge 1 commit into
Open
change(web): support multi-token suggestion similarity 🚂 🔪#15952jahorton wants to merge 1 commit into
jahorton wants to merge 1 commit into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
Bot
added
web/
web/predictive-text/
change
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
2 times, most recently
from
9c45716 to
36c1445
Compare
jahorton
force-pushed
the
change/web/multi-token-suggestion-similarity
branch
from
61fc801 to
96339dc
Compare
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
36c1445 to
c785a39
Compare
jahorton
force-pushed
the
change/web/multi-token-suggestion-similarity
branch
from
96339dc to
4d2321f
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
c785a39 to
4be948f
Compare
jahorton
force-pushed
the
change/web/multi-token-suggestion-similarity
branch
from
4d2321f to
fa050f9
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
4be948f to
dbbe633
Compare
jahorton
force-pushed
the
change/web/multi-token-suggestion-similarity
branch
from
fa050f9 to
2a9c6f2
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
dbbe633 to
415e003
Compare
Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
change/web/multi-token-suggestion-similarity
branch
from
2a9c6f2 to
618e6bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When determining how 'similar' a prediction is to what the user actually typed, it's important to consider the full range of effects of the prediction. Now that this can span multiple context tokens, it's best to simply check if the result of applying the full prediction matches the known context in order to determine similarity and whether or not a specialized 'keep' must be built.
Build-bot: skip build:web
Test-bot: skip