refactor(web): refactor intermediate composited prediction type 🚂 🔪#15951
Open
jahorton wants to merge 2 commits into
Open
refactor(web): refactor intermediate composited prediction type 🚂 🔪#15951jahorton wants to merge 2 commits into
jahorton wants to merge 2 commits into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
023a560 to
4d60591
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
b4a8771 to
9c45716
Compare
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
4d60591 to
21ecf7a
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
9c45716 to
36c1445
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
21ecf7a to
b079a74
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
36c1445 to
c785a39
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
b079a74 to
6e557ee
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
c785a39 to
4be948f
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
5 times, most recently
from
8fd9ef9 to
9a26be5
Compare
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
4be948f to
dbbe633
Compare
This reorganizes the type formerly known as CorrectionPredictionTuple, preparing it to share similarities with a new incoming type handling an earlier, tokenized intermediate stage that will be needed for some aspects of suggestion generation. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/intermediate-composited-prediction
branch
from
dbbe633 to
415e003
Compare
mcdurdin
approved these changes
Jun 22, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
LGTM; the doc comments on the new interfaces are clear and helpful
| if(transformId) { | ||
| p.prediction.sample.transformId = transformId; | ||
| p.metadata.preservationTransform = preservationTransform; | ||
| if(transformId !== undefined) { |
Member
There was a problem hiding this comment.
Good bugfix -- should it have been called out separately?
Base automatically changed from
fix/web/create-default-keep
to
epic/boundary-correction
June 22, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorganizes the type formerly known as
CorrectionPredictionTuple, preparing it to share similarities with a new incoming type (see #15907) handling an earlier, tokenized intermediate stage that will be needed for some aspects of suggestion generation once whitespace-correction comes online.Build-bot: skip build:web
Test-bot: skip