This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Use throwing functions instead of returning a boolean#145
Open
jksk wants to merge 4 commits into
Open
Conversation
Owner
|
@jksk Sorry I have no been maintaining this. I just went through and merged a bunch of PRs. If you want to update the conflicts now I can merge this in. |
Author
|
I updated the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing a small amount of unreproducible failures in production. If something goes wrong, the boolean return value doesn't tell you why. A throwing function contains more information that can be used for debugging.