Migrate test suite from jest to node's built-in test runner#15
Merged
Conversation
Replace jest 27 with node:test and node:assert/strict. All 163 tests pass with coverage via --experimental-test-coverage. Bumps engines to node >=20 (required for stable built-in runner) and drops jest and @types/jest devDependencies.
Required for the built-in test runner used by `npm test`, which is only stable on Node >=20.
actions/checkout@v2 and actions/setup-node@v2 run on Node 16, which GitHub has deprecated. Bump to v4, and setup-python to v5.
Node 22 added native glob expansion for `--test`, but Node 20 (the CI target) does not — quoted globs reach node verbatim and fail with "Could not find". Drop the quotes so sh expands the glob before invoking node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace jest 27 with node:test and node:assert/strict. All 163 tests
pass with coverage via --experimental-test-coverage. Bumps engines to
node >=20 (required for stable built-in runner) and drops jest and
@types/jest devDependencies.