fix(ci): auto-review bot-opened PRs, drop manual review dispatch#1366
Merged
Conversation
The AI review failed on the automated security-fix PRs with "Actor 'github-actions[bot]' is not permitted to run this action". codex-action's write-access check returns permission 'none' for the bot actor and aborts. The reusable ai-review workflow now passes allow-bots: true to codex-action (jitsucom/github-workflows@1.29.20260622), so bot-opened PRs are reviewed normally. Accordingly: - ai-review.yml: bump the reusable workflow ref to 1.29.20260622 and drop the skip-guard (which checked for jitsu-code-review[bot] anyway, while the PRs are actually opened by github-actions[bot], so it never matched). - security-fix.yml: remove the trigger-review job. It manually dispatched the review as a workaround for the failing auto-trigger; now that the auto-trigger works, it would only produce a duplicate review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Reviewed .github/workflows/ai-review.yml and .github/workflows/security-fix.yml for workflow correctness and security impact.
The changes are coherent: the reusable AI-review workflow version now supports bot actors, and removing the manual dispatch from security-fix.yml aligns with the existing PR-triggered AI review path to avoid duplicate review runs. I did not find actionable correctness or security regressions in this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AI Review fails on the automated security-fix PRs (e.g.
security/fix-npm-2026-06-22). The🤖 Run Codex analysisstep aborts with:openai/codex-action's write-access pre-check queries the collaborators API, which returnsnonefor thegithub-actions[bot]actor, so the action exits 1. The previous skip-guard inai-review.ymlchecked forjitsu-code-review[bot]— but these PRs are opened under the repo's ownGITHUB_TOKEN, i.e. actorgithub-actions[bot], so the guard never matched and the auto-trigger ran and failed.Fix
The reusable workflow now passes
allow-bots: trueto codex-action (jitsucom/github-workflows@1.29.20260622), which whitelists the GitHub-ownedgithub-actions[bot]specifically. The review still posts via theAI_CODE_REVIEWapp token (PR write) — the actor check was the only gate.This PR adopts that on the jitsu side:
ai-review.yml: bump the reusable workflow ref1.28.20260529→1.29.20260622, and drop the dead skip-guard so bot-opened PRs are reviewed. Draft PRs are still skipped inside the reusable workflow.security-fix.yml: remove thetrigger-reviewjob. It manually dispatched the review as a workaround for the failing auto-trigger; now that the auto-trigger works, it would only produce a duplicate review per security PR.Upstream change
jitsucom/github-workflows@
1.29.20260622— addsallow-bots: trueto the codex-action step.allow-botsonly trustsgithub-actions[bot](repo-internal automation running under the repo's own token), not arbitrary external actors.🤖 Generated with Claude Code