Fix lexing of string literals ending in an escaped backslash#132
Merged
jg-rp merged 1 commit intoJul 5, 2026
Merged
Conversation
Owner
|
Thanks @gaoflow 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lexer's quoted-string patterns locate the closing quote with a single-character look-behind:
(?<!\\)cannot tell\\"(an escaped backslash followed by the real closing quote) from\"(an escaped quote), so for a name selector whose key ends in an escaped backslash the pattern runs past the real closing quote and a following selector then mis-pairs with a later quote.The visible effect is that JSONPath produces a normalized path it cannot itself read back, which violates RFC 9535 §2.7 (a normalized path must select exactly its node):
That
$['a\\']['b']is python-jsonpath's own generated normalized path for the node, sofindall(match.path, doc)round-trips break.The fix replaces the look-behind with the standard disjoint "unescaped char or backslash-escape" form, which is unambiguous and backtracking-free:
This is the same look-behind bug class fixed in #124 for the regex-literal pattern; that change left the two string-literal patterns untouched. The
re_patternregex-literal pattern is out of scope here.tests/test_escaped_backslash_string_literals.pycovers lexing/parsing of keys ending in escaped backslashes plus normalized-path round-trip and idempotence over several documents. Full suite passes (2793),ruffandmypy --strictclean.