Clean-up package & repo#20
Merged
Merged
Conversation
Without this change, Meson failed in a macOS system with no ninja installation. With the change, it installed and the package tests ran through successfully.
This was the only Intel-based macOS runner that we were running on. So include the macOS-15-intel runner now as well.
According to exclude comments in test_py_sdist, MPICH and Ubuntu 24 don't work correctly.
Build fails if you try to build with C++-11 standard with error message that states that 14 is needed.
12 tasks
These lines were originally in the Taweret installations docs. However, they are most useful here. They are being simultaneously removed from the Taweret docs. This (hopefully) finalizes the decoupling of these two packages.
Installation logs generated when installing the package indicate that the codecs package is now deprecated. We followed suggestions in the log to just use open. This issue was already found and handled identically with surmise. IIRC, the use of codecs was actually causing issues with surmise at some point. I did one successful build with these changes in place.
See notes in test_py_sdist.yml
jcyannotty
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed changes
Pending tasks
Tentative PR Self-review
meson,ninja, oreigeninstalledtoxlogs indicate the need to install both in a build venvmesonv1.10.1 installed from homebrewninjav1.13.2 installed from homebrewbrew cleanup --prune=all -seigeneigenv5.0.1 is pulled down and installed automatically wheneigennot in systemeigenv5.0.1 and v3.4.1 installed via homebrew were found and used bymesonso long aspkgconfwas also installed by homebrew to providepkg-config. Curiously the package is referred to byeigen3inpkg-configfor both versions.otool -Lon installed CLTs looks good and on intermediate library as wellmesonandninjahomebrew installations, cleaned homebrew cache, and confirmed nomesonorninjain PATH.python -m pip cache purgepkgconfwas also installed by homebrew to providepkg-config.otool -Lon CLTs installed in Python package installation looks goodninjaormesoninstallations andninja/mesoninstallation and package building progresses as expectedopenbtmixingfrom this branch rather than PyPI and confirm that its actions are passing as expected