Preserve falsy values (0, False) in jira and latex exports#643
Open
koriyoshi2041 wants to merge 1 commit into
Open
Preserve falsy values (0, False) in jira and latex exports#643koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
The jira and latex serializers used a truthiness test (`if item`) to decide whether a cell is empty, so 0, 0.0, and False were exported as blank cells and silently lost. Only None and empty strings should render as blank, which is what the html format already does (`if item is not None`). Check `item not in (None, '')` instead so real falsy values are kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JIRA and LaTeX serializers decide whether a cell is empty with a plain truthiness test:
So
0,0.0, andFalse— all valid data — are treated as missing and exported as blank cells, silently losing data. For exampletablib.Dataset([0, False, "c"]).jiraproduced| | |c|instead of|0|False|c|.The HTML format already does this correctly with
str(item) if item is not None else "", so "blank only for missing values" is the intended contract. This changes both serializers to testitem not in (None, ""), which keeps the existingNone/empty-string behaviour (still rendered blank) while preserving real falsy values.Added
test_jira_export_falsy_valuesandtest_latex_export_falsy_values; the existing*_none_*tests still pass.pytest -k "jira or latex"is green (12 passed).