Open
Exempt test modules from mypy return type annotation requirement#201
Conversation
Agent-Logs-Url: https://github.com/jaraco/skeleton/sessions/22c20e05-3daf-4a5d-b35e-3acb0e028dd3 Co-authored-by: jaraco <308610+jaraco@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update mypy configuration to exempt test return type declarations
Exempt test modules from mypy return type annotation requirement
May 3, 2026
jaraco
marked this pull request as ready for review
July 12, 2026 17:11
Owner
|
@Avasam Any concerns about this change? |
Avasam
reviewed
Jul 12, 2026
Comment on lines
+19
to
+20
| disable_error_code = | ||
| no-untyped-def, |
Contributor
There was a problem hiding this comment.
From my own shared configs: https://github.com/BesLogic/shared-configs/blob/main/mypy.ini
Also covers my concern at #200 (comment)
And avoids clunkyness trying to expand disable_error_code = downstream
Feel free to reword to your likings
Suggested change
| disable_error_code = | |
| no-untyped-def, | |
| disallow_untyped_defs = false | |
| # Still typecheck the content of test functions, as it validates exposed API usage | |
| check_untyped_defs = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test functions under
tests/**/test_*.pydon't need-> Nonereturn type annotations — they're not part of the public API and aren't shipped in the package. Adding them everywhere is pure noise.Changes
mypy.ini: Adds a[mypy-tests.*]per-module override that disables theno-untyped-deferror code for test modules, so projects using this skeleton no longer need to annotate every test function's return type.