fix(datetime): don't setActiveParts from month/year wheels when multiple=true#31248
Merged
Conversation
…ple=true change event handlers for ion-picker-columns in renderMonthPickerColumn and renderYearPickerColumn to not call setActiveParts when multiple=true closes ionic-team#29673
…ing value depending on multiple property
|
@droc101 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
ShaneK
requested changes
Jun 26, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Awesome, straightforward fix. Just a few change requests
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29673
What is the current behavior?
Using the month/year selection wheels on an
ion-datetimewithmultiple=truechanges the selection in an unintuitive manner and changing the value of one of the wheels often reverts the value of the other wheel.What is the new behavior?
ion-datetimeno longer change the selection whenmultiple=trueion-datetimeis unchanged.renderMonthPickerColumnandrenderYearPickerColumn, as per the docs, themultipleproperty is only supported onpresentation=date preferWheel=false, which only shows those two wheels.Does this introduce a breaking change?