ci: dispatch 12.0 branch release workflow from master release cron#14
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new job to the release GitHub Actions workflow so that every master-branch release check also triggers the 12.0 branch’s release workflow via a workflow_dispatch, using scoped permissions and the existing cron/dispatch schedule. Sequence diagram for master release workflow dispatching 12.0 branch releasesequenceDiagram
participant MasterReleaseWorkflow as master_release.yml
participant DispatchJellyfin12Job as dispatch-jellyfin-12
participant GitHubAPI as GitHub_Actions_API
participant Jellyfin12Workflow as release.yml_12.0
MasterReleaseWorkflow->>DispatchJellyfin12Job: start job dispatch-jellyfin-12
DispatchJellyfin12Job->>GitHubAPI: gh workflow run release.yml --ref 12.0
GitHubAPI->>Jellyfin12Workflow: workflow_dispatch event
Jellyfin12Workflow->>Jellyfin12Workflow: compare_master_sha_and_release_if_changed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding an
if:condition ondispatch-jellyfin-12so it only runs on the intended events (e.g. schedule andrepository_dispatch) and doesn’t trigger on unrelated workflow invocations like push/PR runs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding an `if:` condition on `dispatch-jellyfin-12` so it only runs on the intended events (e.g. schedule and `repository_dispatch`) and doesn’t trigger on unrelated workflow invocations like push/PR runs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by step-3.7-flash · Input: 92.7K · Output: 5.1K · Cached: 33.2K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 12.0 branch (Jellyfin 12 build of the plugin) never auto-releases because scheduled and
repository_dispatchevents only execute workflows from the default branch. This adds adispatch-jellyfin-12job to the release workflow that forwards every release check to the 12.0 branch viagh workflow run release.yml --ref 12.0, riding the existing 30-minute cron and dispatch triggers.needs:on the master release job); the 12.0 branch's own workflow compares the recordedsegment-editormaster SHA and only releases on actual upstream changes, so forwarded no-op checks are cheap and the setup self-heals after failed runspermissions: actions: writescopes the token to the dispatch API only;workflow_dispatchis one of the two documented exceptions to the "GITHUB_TOKEN events don't trigger workflow runs" rule, so the dispatched run actually startsMerge #13 (the 12.0-branch workflow rework) before this one: the old 12.0 workflow released unconditionally on every dispatch and pushed version bumps to the default branch.
Summary by Sourcery
CI: