Skip to content

ci: dispatch 12.0 branch release workflow from master release cron#14

Merged
rlauuzo merged 1 commit into
masterfrom
capy/ci-dispatch-120-branch
Jul 17, 2026
Merged

ci: dispatch 12.0 branch release workflow from master release cron#14
rlauuzo merged 1 commit into
masterfrom
capy/ci-dispatch-120-branch

Conversation

@rlauuzo

@rlauuzo rlauuzo commented Jul 17, 2026

Copy link
Copy Markdown
Member

The 12.0 branch (Jellyfin 12 build of the plugin) never auto-releases because scheduled and repository_dispatch events only execute workflows from the default branch. This adds a dispatch-jellyfin-12 job to the release workflow that forwards every release check to the 12.0 branch via gh workflow run release.yml --ref 12.0, riding the existing 30-minute cron and dispatch triggers.

  • The job dispatches unconditionally (no needs: on the master release job); the 12.0 branch's own workflow compares the recorded segment-editor master SHA and only releases on actual upstream changes, so forwarded no-op checks are cheap and the setup self-heals after failed runs
  • Job-level permissions: actions: write scopes the token to the dispatch API only; workflow_dispatch is one of the two documented exceptions to the "GITHUB_TOKEN events don't trigger workflow runs" rule, so the dispatched run actually starts

Merge #13 (the 12.0-branch workflow rework) before this one: the old 12.0 workflow released unconditionally on every dispatch and pushed version bumps to the default branch.

Open in Capy

Summary by Sourcery

CI:

  • Add a dispatch job that runs the 12.0 branch release workflow on the existing master release cron using scoped actions permissions.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@rlauuzo rlauuzo added the capy Generated by capy.ai label Jul 17, 2026 — with Capy AI
@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new job to the release GitHub Actions workflow so that every master-branch release check also triggers the 12.0 branch’s release workflow via a workflow_dispatch, using scoped permissions and the existing cron/dispatch schedule.

Sequence diagram for master release workflow dispatching 12.0 branch release

sequenceDiagram
  participant MasterReleaseWorkflow as master_release.yml
  participant DispatchJellyfin12Job as dispatch-jellyfin-12
  participant GitHubAPI as GitHub_Actions_API
  participant Jellyfin12Workflow as release.yml_12.0

  MasterReleaseWorkflow->>DispatchJellyfin12Job: start job dispatch-jellyfin-12
  DispatchJellyfin12Job->>GitHubAPI: gh workflow run release.yml --ref 12.0
  GitHubAPI->>Jellyfin12Workflow: workflow_dispatch event
  Jellyfin12Workflow->>Jellyfin12Workflow: compare_master_sha_and_release_if_changed
Loading

File-Level Changes

Change Details Files
Forward master release checks to the 12.0 branch workflow via a dedicated dispatch job.
  • Introduce a new GitHub Actions job dispatch-jellyfin-12 that always runs alongside the main release job.
  • Configure the job to run on ubuntu-latest with job-level permissions: actions: write so the GITHUB_TOKEN can call the actions dispatch API.
  • Add a step that sets GH_TOKEN from secrets.GITHUB_TOKEN and invokes gh workflow run release.yml --repo "${{ github.repository }}" --ref 12.0 to trigger the 12.0 branch’s release workflow on each master release check.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding an if: condition on dispatch-jellyfin-12 so it only runs on the intended events (e.g. schedule and repository_dispatch) and doesn’t trigger on unrelated workflow invocations like push/PR runs.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding an `if:` condition on `dispatch-jellyfin-12` so it only runs on the intended events (e.g. schedule and `repository_dispatch`) and doesn’t trigger on unrelated workflow invocations like push/PR runs.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kilo-code-bot

kilo-code-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/release.yml

Reviewed by step-3.7-flash · Input: 92.7K · Output: 5.1K · Cached: 33.2K

@rlauuzo
rlauuzo merged commit 28b79e5 into master Jul 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capy Generated by capy.ai

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant