maint: migrate various data sources to tflog structured logging#3347
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
Please remove the resolves comment, since it adresses the issue only partly. And "resolves" will close the issue |
|
I just removed it from the description |
|
Would you be available to rebase this (possibly multiple times) during the next week? We're going to release 6.13.0 and will try to land some of these open PRs |
|
I've updated the branch and I'm available to rebase again if needed. |
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @slymanmrcan. Could you please make sure that the tflog calls in this PR are all single line.
45b0c54 to
98c6651
Compare
robert-crandall
left a comment
There was a problem hiding this comment.
Thanks for chipping away at #3070! This is a clean, well-scoped move to structured logging - builds, vets, and formats cleanly on my end, and it lines up nicely with how tflog is already used elsewhere in the provider.
|
@slymanmrcan Please rebase so that we can merge this :) |
98c6651 to
ee80502
Compare
Addresses parts of #3070
Before the change?
"Logging was using the standard Go log package, which outputs unstructured text to stdout."
After the change?
"Migrated selected data sources to use tflog for structured logging. This allows for better log filtering and follows the Terraform Plugin SDK v2 best practices."
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!