Skip to content

maint: migrate various data sources to tflog structured logging#3347

Merged
deiga merged 1 commit into
integrations:mainfrom
slymanmrcan:refactor/tflog-migration-3070
Jun 19, 2026
Merged

maint: migrate various data sources to tflog structured logging#3347
deiga merged 1 commit into
integrations:mainfrom
slymanmrcan:refactor/tflog-migration-3070

Conversation

@slymanmrcan

@slymanmrcan slymanmrcan commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Addresses parts of #3070

Before the change?

"Logging was using the standard Go log package, which outputs unstructured text to stdout."

After the change?

"Migrated selected data sources to use tflog for structured logging. This allows for better log filtering and follows the Terraform Plugin SDK v2 best practices."

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga

deiga commented Apr 18, 2026

Copy link
Copy Markdown
Collaborator

Please remove the resolves comment, since it adresses the issue only partly. And "resolves" will close the issue

@deiga deiga added this to the v6.13.0 Release milestone Apr 18, 2026
@deiga deiga added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Apr 18, 2026
@slymanmrcan

Copy link
Copy Markdown
Contributor Author

I just removed it from the description

deiga
deiga previously approved these changes Apr 18, 2026
@deiga

deiga commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Would you be available to rebase this (possibly multiple times) during the next week? We're going to release 6.13.0 and will try to land some of these open PRs

@slymanmrcan

Copy link
Copy Markdown
Contributor Author

I've updated the branch and I'm available to rebase again if needed.

@stevehipwell stevehipwell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @slymanmrcan. Could you please make sure that the tflog calls in this PR are all single line.

@slymanmrcan slymanmrcan force-pushed the refactor/tflog-migration-3070 branch 3 times, most recently from 45b0c54 to 98c6651 Compare June 17, 2026 21:59

@stevehipwell stevehipwell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-crandall robert-crandall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for chipping away at #3070! This is a clean, well-scoped move to structured logging - builds, vets, and formats cleanly on my end, and it lines up nicely with how tflog is already used elsewhere in the provider.

@deiga

deiga commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

@slymanmrcan Please rebase so that we can merge this :)

@slymanmrcan slymanmrcan force-pushed the refactor/tflog-migration-3070 branch from 98c6651 to ee80502 Compare June 19, 2026 08:50
@deiga deiga merged commit d2782b0 into integrations:main Jun 19, 2026
13 of 19 checks passed
@slymanmrcan slymanmrcan deleted the refactor/tflog-migration-3070 branch June 19, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants