Breakpoints are set from sharedTokens#2602
Open
matyasf wants to merge 1 commit into
Open
Conversation
|
matyasf
force-pushed
the
unify_breakpoints
branch
from
c6905a7 to
cddecab
Compare
FormFieldLayout and Grid now uses design tokens from sharedTokens to set breakpoint values. Document app has fewer CSS breakpoints and their value are the same as the breakpoints in SharedTokens. update button example in regression test with more valuers INSTUI-5074
matyasf
force-pushed
the
unify_breakpoints
branch
from
cddecab to
d72271d
Compare
Visual regression report
Diff images (1)button-and-derivatives.png — 98193 pixels differBaselines come from the |
matyasf
commented
Jun 23, 2026
| private navFocusRegion: FocusRegion | null = null | ||
|
|
||
| static defaultProps = { | ||
| trayWidth: 300 |
Collaborator
Author
There was a problem hiding this comment.
For some reason from ancient times, the App component had this prop. It's now hardcoded
adamlobler
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
INSTUI-5074