fix(logger): handle EPIPE/ECONNRESET errors on stdout/stderr to prevent process crash#682
Open
icebear0828 wants to merge 1 commit into
Open
fix(logger): handle EPIPE/ECONNRESET errors on stdout/stderr to prevent process crash#682icebear0828 wants to merge 1 commit into
icebear0828 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
容器/pipe 断开时,Node.js 会向 stdout/stderr 发
error事件,未处理会导致进程崩溃。在wrap()里调用原始 write 方法时如果抛EPIPE,也会上抛给调用方。修复
installFileLogger()注册error事件处理器,静默吞掉EPIPE/ECONNRESET,其他错误继续throwuninstall()时同步off解绑,避免 listener 泄漏wrap()内部的原始 write 调用包try/catch,抛错时返回false而不是崩测试
falseExtracted from #675.