fix: #2147 preserve sub-millisecond precision in trace waterfall timestamps#2158
fix: #2147 preserve sub-millisecond precision in trace waterfall timestamps#2158nquandt wants to merge 5 commits intohyperdxio:mainfrom
Conversation
|
@nquandt-mt is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
|
PR Review✅ No critical issues found. The implementation correctly extracts sub-millisecond precision from nanosecond timestamps. The key formula in ts.toDate().getTime() + (ts.getNano() % 1_000_000) / 1_000_000—
|
8b9aa54 to
126f572
Compare
126f572 to
32b4fd1
Compare
|
After fighting with the Claude Code Review bot, I think this is in a good spot. I have no further changes at this time. |
fix: #2147
Summary
Move parseTimestampToMs to src/utils.ts and import it in DBTraceWaterfallChart. Uses TimestampNano to avoid truncation from new Date().getTime(), preventing alignment errors when two events fall within the same millisecond.
Screenshots or video
Before:

After:

How to test locally or on Vercel
References
#2147