Skip to content

bar chart support#2005

Open
gingerwizard wants to merge 6 commits intohyperdxio:mainfrom
gingerwizard:bar_chart
Open

bar chart support#2005
gingerwizard wants to merge 6 commits intohyperdxio:mainfrom
gingerwizard:bar_chart

Conversation

@gingerwizard
Copy link
Copy Markdown
Contributor

Summary

This PR introduces Bar Charts. Historically, bar charts were effectively bar charts over time series. This implements true bar charts where the x-axis can be any grouping key.

As a result of this, line/bar charts are now called "Time Series"

Screenshots or video

image

How to test locally or on Vercel

  1. Navigate to Chart Explorer.
  2. Build a bar chart - Demo Traces - Group by ServiceName

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2026

@gingerwizard is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 28, 2026

⚠️ No Changeset found

Latest commit: fa802a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 28, 2026

PR Review

  • .env version downgrade: CODE_VERSION reverted from 2.24.12.23.0 and OTEL_COLLECTOR_VERSION/OTEL_COLLECTOR_CORE_VERSION deleted — this looks like a stale-branch merge artifact; rebase on main and drop these .env changes before merging

  • ⚠️ DBBarChart reuses formatResponseForPieChart for data formatting — works today since formats are identical, but rename or extract to a shared util (e.g. formatResponseForCategoricalChart) to avoid confusion when the two diverge

  • ⚠️ limit field type is { limit?: number } — the same-name double nesting (limit.limit) is confusing; consider { value?: number } or a flat limitCount?: number

  • ⚠️ convertToInternalTileConfig in dashboards.ts (line ~397): bar is silently grouped under the table/number/pie SQL config case-fall-through via a chained ternary that grows unboundedly — a switch on externalConfig.displayType for the DisplayType.* mapping would be safer and more readable

✅ Logic, validation, schema, tests, and tile-sizing changes all look correct.

Comment thread packages/app/src/components/ChartEditor/utils.ts
Comment thread packages/app/src/components/ChartDisplaySettingsDrawer.tsx
Comment thread packages/app/src/components/ChartDisplaySettingsDrawer.tsx
Comment thread packages/app/src/components/DBBarChart.tsx
Comment thread packages/app/src/components/DBBarChart.tsx Outdated
Comment thread packages/app/src/components/DBBarChart.tsx Outdated
Comment thread packages/app/src/components/DBEditTimeChartForm.tsx Outdated
Comment thread packages/common-utils/src/types.ts
@github-actions github-actions Bot added the review/tier-4 Critical — deep review + domain expert sign-off label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

🟡 Tier 3 — Standard

Introduces new logic, modifies core functionality, or touches areas with non-trivial risk.

Why this tier:

  • Cross-layer change: touches frontend (packages/app) + shared utils (packages/common-utils)

Review process: Full human review — logic, architecture, edge cases.
SLA: First-pass feedback within 1 business day.

Stats
  • Production files changed: 10
  • Production lines changed: 407 (+ 13 in test files, excluded from tier calculation)
  • Branch: bar_chart
  • Author: gingerwizard

To override this classification, remove the review/tier-3 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions github-actions Bot added review/tier-3 Standard — full human review required and removed review/tier-4 Critical — deep review + domain expert sign-off labels Apr 6, 2026
Copy link
Copy Markdown
Contributor

@pulpdrew pulpdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The bar chart is no longer showing up on the chart builder, after updating the branch
  • The OpenAPI specs should be updated with the new display type in packages/api/src/routers/external-api/v2/dashboards.ts
  • Please address the failing integration tests (make ci-int to run locally, this might just be due to the changes to the env file) and knip check (yarn knip)

Comment thread .env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-3 Standard — full human review required waiting-on-author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants