bar chart support#2005
Conversation
|
@gingerwizard is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
|
PR Review
✅ Logic, validation, schema, tests, and tile-sizing changes all look correct. |
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Review process: Full human review — logic, architecture, edge cases. Stats
|
pulpdrew
left a comment
There was a problem hiding this comment.
- The bar chart is no longer showing up on the chart builder, after updating the branch
- The OpenAPI specs should be updated with the new display type in packages/api/src/routers/external-api/v2/dashboards.ts
- Please address the failing integration tests (
make ci-intto run locally, this might just be due to the changes to the env file) and knip check (yarn knip)
Summary
This PR introduces Bar Charts. Historically, bar charts were effectively bar charts over time series. This implements true bar charts where the x-axis can be any grouping key.
As a result of this, line/bar charts are now called "Time Series"
Screenshots or video
How to test locally or on Vercel